From 3c98dc8ad36109048b4d24ef36942caec8227af9 Mon Sep 17 00:00:00 2001 From: Antoine Beyeler Date: Thu, 27 Jun 2024 18:22:45 +0200 Subject: [PATCH] Fix visible time range help string --- crates/re_selection_panel/src/defaults_ui.rs | 3 ++- .../src/visible_time_range_ui.rs | 21 ++++++------------- 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/crates/re_selection_panel/src/defaults_ui.rs b/crates/re_selection_panel/src/defaults_ui.rs index e79648da4c0ac..4b10e4629221a 100644 --- a/crates/re_selection_panel/src/defaults_ui.rs +++ b/crates/re_selection_panel/src/defaults_ui.rs @@ -104,7 +104,8 @@ fn active_default_ui( .get_by_identifier(*visualizer_identifier) else { re_log::warn!( - "Failed to resolve visualizer identifier {visualizer_identifier}, to a visualizer implementation" + "Failed to resolve visualizer identifier {visualizer_identifier}, to a \ + visualizer implementation" ); continue; }; diff --git a/crates/re_selection_panel/src/visible_time_range_ui.rs b/crates/re_selection_panel/src/visible_time_range_ui.rs index a4bae7254810d..746149462b3a0 100644 --- a/crates/re_selection_panel/src/visible_time_range_ui.rs +++ b/crates/re_selection_panel/src/visible_time_range_ui.rs @@ -176,27 +176,18 @@ fn query_range_ui( let time_type = time_ctrl.timeline().typ(); let mut interacting_with_controls = false; - let markdown = format!( - "# Visible time range\n + let markdown = "# Visible time range\n This feature controls the time range used to display data in the space view. -The settings are inherited from the parent entity or enclosing space view if not overridden. - -Visible time range properties are stored separately for each _type_ of timelines. They may differ \ -depending on whether the current timeline is temporal or a sequence. The current settings apply to \ -all _{}_ timelines. - -Notes that the data current as of the time range starting time is included.", - match time_type { - TimeType::Time => "temporal", - TimeType::Sequence => "sequence", - } - ); +Notes: +- The settings are inherited from the parent entity or enclosing space view if not overridden. +- Visible time range properties are stored on a per-timeline basis. +- The data current as of the time range starting time is included."; let collapsing_response = ui .section_collapsing_header("Visible time range") .default_open(false) - .help_markdown(&markdown) + .help_markdown(markdown) .show(ui, |ui| { ui.horizontal(|ui| { ui.re_radio_value(has_individual_time_range, false, "Default")