-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom window frames for Windows and Linux #1063
Comments
There are a bunch of open issues with custom window frames in |
Custom decorations working fine on Linux/Wayland/Sway. /// If true, we fill the entire window, except for the close/maximize/minimize buttons in the top-left.
/// See <https://github.com/emilk/egui/pull/2049>
-pub const FULLSIZE_CONTENT: bool = cfg!(target_os = "macos");
+pub const FULLSIZE_CONTENT: bool = true;
/// If true, we hide the native window decoration
/// (the top bar with app title, close button etc),
/// and instead paint our own close/maximize/minimize buttons.
-pub const CUSTOM_WINDOW_DECORATIONS: bool = false; // !FULLSIZE_CONTENT; // TODO(emilk): https://github.com/rerun-io/rerun/issues/1063
+pub const CUSTOM_WINDOW_DECORATIONS: bool = true; // !FULLSIZE_CONTENT; // TODO(emilk): https://github.com/rerun-io/rerun/issues/1063 Close button works as expected -- others don't but that's expected on my setup. |
You work for the wrong company 😅 |
I'm pretty sure if me or @nikolausWest worked on a Linux or Windows machine, this issue would have a much higher priority |
Currently the viewer frame on Windows and Linux have an ugly platform-specific header with a title, close buttons, and a minimize button.
We should just replace those with our own window frame, like in https://github.com/emilk/egui/tree/master/examples/custom_window_frame
TODO:
paint_time_ranges_gaps
). Maybe turn off rounding?I think we need to center the panel buttons?What Rerun currently looks like on Gnome/xorg:
If you enable
CUSTOM_WINDOW_DECORATIONS
onmain
:The text was updated successfully, but these errors were encountered: