Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Component's DataType should embed its metadata #1696

Closed
Tracked by #1619 ...
teh-cmc opened this issue Mar 23, 2023 · 2 comments · Fixed by #6439
Closed
Tracked by #1619 ...

A Component's DataType should embed its metadata #1696

teh-cmc opened this issue Mar 23, 2023 · 2 comments · Fixed by #6439
Assignees
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏹 arrow concerning arrow 🧑‍💻 dev experience developer experience (excluding CI)

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Mar 23, 2023

Currently we need to carry around components' metadata (e.g. ComponentName) everywhere, because the DataType in erased arrow arrays doesn't give us any information about the component type.

This is a real issue as it prevents using DataCell in more places (too much overhead if every cell carries a ComponentName).

The solution for this is arrow2's Extension datatype; but we need to improve on the ArrowField derive macro first, so that we can specify extension metadata easily... otherwise we'd have to manually implement ArrowField for everything.

@teh-cmc teh-cmc added 🏹 arrow concerning arrow 🧑‍💻 dev experience developer experience (excluding CI) 😤 annoying Something in the UI / SDK is annoying to use labels Mar 23, 2023
@teh-cmc
Copy link
Member Author

teh-cmc commented Mar 23, 2023

Also: we have effectively no way of knowing whether a datatype corresponds to a cell or a whole column (or even a whole table?) just by looking at it (a component could be a list of list of list in and of itself), which is annoying.

@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 9, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏹 arrow concerning arrow 🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant