Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure implicit instance counts have been wiped everywhere #1892

Closed
Tracked by #1619
teh-cmc opened this issue Apr 18, 2023 · 1 comment
Closed
Tracked by #1619

Make sure implicit instance counts have been wiped everywhere #1892

teh-cmc opened this issue Apr 18, 2023 · 1 comment
Labels
⛃ re_datastore affects the datastore itself 🔍 re_query affects re_query itself

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Apr 18, 2023 •
edited
Loading

With the new num_instances column stored and exposed, we need to make sure nothing still relies on the old implicit way of doing things (SDK, store, query layer).
@teh-cmc teh-cmc mentioned this issue Apr 18, 2023
Closed
18 tasks
@teh-cmc teh-cmc changed the title Implement explicit number of instances Make sure implicit instance count have been wiped everywhere Apr 18, 2023
@teh-cmc teh-cmc added ⛃ re_datastore affects the datastore itself 🔍 re_query affects re_query itself labels Apr 18, 2023
@teh-cmc teh-cmc changed the title Make sure implicit instance count have been wiped everywhere Make sure implicit instance counts have been wiped everywhere Apr 18, 2023
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 23, 2023

Done afaict.

@teh-cmc teh-cmc closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⛃ re_datastore affects the datastore itself 🔍 re_query affects re_query itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teh-cmc