Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setup_web.sh with something more robust #2174

Closed
jleibs opened this issue May 19, 2023 · 1 comment
Closed

Replace setup_web.sh with something more robust #2174

jleibs opened this issue May 19, 2023 · 1 comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) enhancement New feature or request

Comments

@jleibs
Copy link
Member

jleibs commented May 19, 2023

setup_web.sh is currently used to install both wasm-bindgen-cli and binaryen.

It has a few problems that keeps it from being portable:

  • depends on a bash shell
  • windows doesn't have a package manager in CI
  • The installed binaryen isn't versioned and the version installed on 20.04 is too old
  • The script will still fail even if the packages were manually installed correctly.

The basic logic should be:

  • Check that the packages are installed with the correct version. If yes, always return as a no-op.
  • If no, try to install with appropriate system package manager target.
  • If that doesn't work, link to instructions for manual installation and fail.
@jleibs jleibs added enhancement New feature or request 🧑‍💻 dev experience developer experience (excluding CI) labels May 19, 2023
@jleibs
Copy link
Member Author

jleibs commented Nov 28, 2023

This is now duplicated by the other pixi-related work.

@jleibs jleibs closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant