Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintuitive default split when logging three images #3984

Open
roym899 opened this issue Oct 24, 2023 · 2 comments
Open

Unintuitive default split when logging three images #3984

roym899 opened this issue Oct 24, 2023 · 2 comments
Labels
😤 annoying Something in the UI / SDK is annoying to use 📺 re_viewer affects re_viewer itself ui concerns graphical user interface

Comments

@roym899
Copy link
Collaborator

roym899 commented Oct 24, 2023

Describe the annoyance
When logging exactly three images to separate entity paths, the first image will be in its own pane, with the remaining two sharing an extra grid pane. It's a bit annoying to rearrange into a view where all images have the same size. This seems to only happen when logging exactly three images.

To Reproduce

import rerun as rr
import numpy as np

rr.init("test", spawn=True)

rr.log("image1", rr.Image(np.random.rand(100,100,3)))
rr.log("image2", rr.Image(np.random.rand(100,100,3)))
rr.log("image3", rr.Image(np.random.rand(100,100,3)))
# rr.log("image4", rr.Image(np.random.rand(100,100,3)))

Expected behavior
All images should appear in a consistent way in the viewer (i.e., all taking the same amount of space).

Additional context

rerun_py 0.10.0-alpha.7+dev [rustc 1.72.1 (d5c2e9c34 2023-09-13), LLVM 16.0.5] x86_64-unknown-linux-gnu main 47414c8, built 2023-10-24T12:00:38Z
@roym899 roym899 added 😤 annoying Something in the UI / SDK is annoying to use 👀 needs triage This issue needs to be triaged by the Rerun team labels Oct 24, 2023
@Wumpf
Copy link
Member

Wumpf commented Oct 24, 2023

@emilk something we want to consider fixing in the default tiling or close as won't fix with explicit user blueprint as the future solution?

@emilk emilk added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Nov 6, 2023
@emilk
Copy link
Member

emilk commented Nov 6, 2023

I think the problem here is that we have a heuristic for the default arrangement that will never be perfect.

The current heuristic is not smart enough to know that some of the space-views have a fixed aspect ratios (as 2D space-view have, but 3D space-views do not). Adding this support is possible, but challenging.

The real solution is to make it easier for users to change the default from code and in the UI:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

3 participants