Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how component value clamping is represented in the "latest at" dataframe #6910

Closed
abey79 opened this issue Jul 16, 2024 · 1 comment
Labels
feat-dataframe-view Everything related to the dataframe view ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Jul 16, 2024

After #6894, components which have a lower-than-max instance count have their last value "duplicated" with a dimmer style, to represent the clamplng:

image

It is not entirely clear that this is a good design:

  • For starters, we're displaying data where there is none, which may contrary to the basic idea of the data table.
  • The actual clamping behaviour is very much visualiser dependant. It's often done against some primary/required component (e.g. Positions3D), and not "whichever component happens to have the most instances". In some case (e.g. mesh), clamping makes no sense whatsoever. There exists other cases with different behaviour. So any clamping behaviour shown in the dataframe view has high chances of not being actually representative of what happens elsewhere.

For example, see here Position3D being clamped against TriangleIndices, which makes no sense:

image

Possible avenues

  • Have some archetype-level metadata to specify the actual clamping behaviour, and the possibility to somehow choose an archetype "point of view" for the dataframe (which, as data filtering UI goes, would be pretty interesting beyond the mere question of clamping display).
  • Have some heuristics to, e.g., only clamp component with length = 1 (aka "splat), as opposed to clamping component with different, >1 lengths as for meshes.

Design

Design proposal by @gavrelina to improve how clamped value are represented:

clumped.mp4
@abey79
Copy link
Member Author

abey79 commented Sep 9, 2024

@abey79 abey79 closed this as completed Sep 9, 2024
@abey79 abey79 added the feat-dataframe-view Everything related to the dataframe view label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat-dataframe-view Everything related to the dataframe view ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

1 participant