Boxes3DVisualizer does not account for rotations when computing bounding boxes

[kpreid]

Describe the bug

The visualizer ignores the rotations component when computing the bounding box of the batch of boxes.

rerun/crates/viewer/re_space_view_spatial/src/visualizers/boxes3d.rs

Lines 79 to 85 in 05853c6

	let centers = clamped_or(data.centers, &Position3D::ZERO);
	let rotations = clamped_or(data.rotations, &Rotation3D::IDENTITY);
	for (i, (half_size, &center, rotation, radius, &color)) in
	itertools::izip!(data.half_sizes, centers, rotations, radii, &colors).enumerate()
	{
	obj_space_bounding_box.extend(half_size.box_min(center));
	obj_space_bounding_box.extend(half_size.box_max(center));

To Reproduce

1. Open an example with rotated boxes, such as cargo run --bin snippets -- box3d_batch
2. Click on “Show bounding box”
3. Observe the boxes escaping the box.

Screenshots

Rerun version
Commit 05853c6

[Wumpf]

Good find!
Taking this over - rotation is going to be removed as part of #6831 but we then need to make sure that the new transform / out of tree transform is handling the bbox correctly

[kpreid]

I believe I fixed this bug as a drive-by in #6953 (since it was simpler than deliberately keeping the bug in place). Sorry for not mentioning that more precisely — but it sounds like you want to use this to track checking on the next implementation, so I won't just hit the close button.