Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce cheaply clonable ChunkStoreHandle and QueryCacheHandle #7486

Closed
teh-cmc opened this issue Sep 24, 2024 · 1 comment · Fixed by #7934
Closed

Introduce cheaply clonable ChunkStoreHandle and QueryCacheHandle #7486

teh-cmc opened this issue Sep 24, 2024 · 1 comment · Fixed by #7934
Assignees
Labels
⛃ re_datastore affects the datastore itself 🔍 re_query affects re_query itself 🦀 Rust API Rust logging API

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Sep 24, 2024

These are required for:

  1. Making it easy to construct and pass QueryEngines around:
// TODO(cmc): This needs to be a refcounted type that can be easily be passed around: the ref has
// got to go. But for that we need to generally introduce `ChunkStoreHandle` and `QueryCacheHandle`
// first, and this is not as straightforward as it seems.
pub struct QueryEngine<'a> {
    pub store: &'a ChunkStore,
    pub cache: &'a Caches,
}
  1. Getting ingestion off of the main thread and parallelize it:
@teh-cmc teh-cmc added 🦀 Rust API Rust logging API ⛃ re_datastore affects the datastore itself 🔍 re_query affects re_query itself labels Sep 24, 2024
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 3, 2024

@zehiko just hit that one as he was trying to integrate a QueryHandle/QueryEngine into an async Stream (which assumes multi-threaded environment, and therefore static lifetimes, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛃ re_datastore affects the datastore itself 🔍 re_query affects re_query itself 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants