Remove the Option<RowId>
argument in ComponentUiRegistry
's methods
#7617
Labels
Option<RowId>
argument in ComponentUiRegistry
's methods
#7617
The reason for this argument to exist in the first place is to have the value around for the code paths which lead to
EntityDataUi::entity_data_ui
.Of the remaining implementations of
EntityDataUi
, onlyBlob
andTensorData
actually make use of the row id, as a cache key. PassingNone
implicitly disable the thumbnail display. (Note that this can be a good thing in some contexts such as the dataframe view, because the cost of displaying those thumbnails is currently pretty high.)Note that one codepath exists (
<InstancePath as DataUi>::data_ui()
) where the row id is obtained while reading the component itself.In any case,
EntityDataUi
is meant to be removed (#6661), so thisrow_id
argument should be removed everywhere.The text was updated successfully, but these errors were encountered: