Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Option<RowId> argument in ComponentUiRegistry's methods #7617

Open
abey79 opened this issue Oct 7, 2024 · 0 comments
Open

Remove the Option<RowId> argument in ComponentUiRegistry's methods #7617

abey79 opened this issue Oct 7, 2024 · 0 comments
Labels
📺 re_viewer affects re_viewer itself ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Oct 7, 2024

The reason for this argument to exist in the first place is to have the value around for the code paths which lead to EntityDataUi::entity_data_ui.

Of the remaining implementations of EntityDataUi, only Blob and TensorData actually make use of the row id, as a cache key. Passing None implicitly disable the thumbnail display. (Note that this can be a good thing in some contexts such as the dataframe view, because the cost of displaying those thumbnails is currently pretty high.)

Note that one codepath exists (<InstancePath as DataUi>::data_ui()) where the row id is obtained while reading the component itself.

In any case, EntityDataUi is meant to be removed (#6661), so this row_id argument should be removed everywhere.

@abey79 abey79 added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

1 participant