Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure our filter and take kernels early-out where possible #7632

Closed
teh-cmc opened this issue Oct 8, 2024 · 0 comments · Fixed by #7704
Closed

Make sure our filter and take kernels early-out where possible #7632

teh-cmc opened this issue Oct 8, 2024 · 0 comments · Fixed by #7704
Assignees
@teh-cmc
Labels
🏹 arrow concerning arrow 🚀 performance Optimization, memory use, etc
Milestone
0.19 - Dataframe ...

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Oct 8, 2024

I'm pretty sure the implementations in Arrow don't:

  • Make sure filter() simplifies to a no-op if the filter is a full-mask.
  • Make sure take() simplifies to a no-op if the indices cover the whole range in order.
@teh-cmc teh-cmc added 🏹 arrow concerning arrow 🚀 performance Optimization, memory use, etc labels Oct 8, 2024
@teh-cmc teh-cmc added this to the 0.19 - Dataframe and web video milestone Oct 8, 2024
@teh-cmc teh-cmc self-assigned this Oct 12, 2024
@teh-cmc teh-cmc mentioned this issue Oct 12, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
🏹 arrow concerning arrow 🚀 performance Optimization, memory use, etc
Projects
None yet
Milestone
0.19 - Dataframe and video
Development

Successfully merging a pull request may close this issue.

Make sure Arrow filter and take kernels early out where it makes sense rerun-io/rerun
1 participant
@teh-cmc