Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DisconnectedSpace, replace with pure transform marker type InvalidTransform/UndefinedTransform (tbd) #7868

Closed
Wumpf opened this issue Oct 22, 2024 · 0 comments · Fixed by #8459
Labels
🍏 primitives Relating to Rerun primitives

Comments

@Wumpf
Copy link
Member

Wumpf commented Oct 22, 2024

While sitting over

@jleibs and me realized that given how the rest of the Viewer evolved the concept of a "disconnected" space no longer makes sense: it's not trivial to configure entity path expressions to achieve what we previously tried to achieve with DisconnectedSpace

We still want a pure spatial (not topological like DisconnectedSpace) property that disonnects the transform tree itself. This would not have any effect on either

  • internal topology
  • heuristics
  • visualizability

I.e. this preserves what we handle within the transform context as UnreachableTransformReason::DisconnectedSpace, but removes all other aspects of disconnected space.


We should introduce this new archetype and deprecated DisconnectedSpace in the same release, making it equivalent to the new type as long as it is shipped under a deprecation mark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍏 primitives Relating to Rerun primitives
Projects
None yet
1 participant