Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid assertions in release builds (assert!, panic!) #7997

Open
teh-cmc opened this issue Nov 5, 2024 · 1 comment
Open

Forbid assertions in release builds (assert!, panic!) #7997

teh-cmc opened this issue Nov 5, 2024 · 1 comment
Labels
💣 crash crash, deadlock/freeze, do-no-start 🧑‍💻 dev experience developer experience (excluding CI) 🔨 testing testing and benchmarks

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Nov 5, 2024

I cannot think of any legitimate use case for release assertions for Rerun in non-test code. We never want the viewer to crash, nor the SDK.

The existing clippy machinery doesn't seem capable of differentiating between app code and test code, unfortunately.

Update: build scripts, compile-time code and other codegen shenanigans are another example where it's fine.

@teh-cmc teh-cmc added 🔨 testing testing and benchmarks 🧑‍💻 dev experience developer experience (excluding CI) 💣 crash crash, deadlock/freeze, do-no-start labels Nov 5, 2024
@Wumpf
Copy link
Member

Wumpf commented Nov 6, 2024

Related to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💣 crash crash, deadlock/freeze, do-no-start 🧑‍💻 dev experience developer experience (excluding CI) 🔨 testing testing and benchmarks
Projects
None yet
Development

No branches or pull requests

2 participants