Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph layout for multiple entities #8126

Closed
Tracked by #7897
grtlr opened this issue Nov 13, 2024 · 1 comment
Closed
Tracked by #7897

Graph layout for multiple entities #8126

grtlr opened this issue Nov 13, 2024 · 1 comment
Labels
feat-graph-view Everything related to the graph view 👀 needs triage This issue needs to be triaged by the Rerun team other Generated by the "Other" issue template

Comments

@grtlr
Copy link
Contributor

grtlr commented Nov 13, 2024

#7500 implements a basic graph viewer. One thing that I'm not entirely sure about is how to handle multiple entities in a single graph viewer.

Some context: Since graph layouts are hard (and users have different preferences) we wanted to be able to specify node positions for each node in the new GraphNodes archetype. We now have to think about how we want to show multiple entities in the graph viewer. In particular, I'm wondering if the entities should:

  1. all share the same global coordinate system and a global layouting algorithm
  2. each entity has its own local coordinate system within a common viewer each with its own layouting algorithm

So far @abey79 and I have leaned towards (2) to prevent overlap between graphs from different entities. Thinking some more about this, we probably should go with approach (1), as the overlap can be a feature: it will allow the user to compose larger graphs from smaller entities (each with their own properties).

The biggest benefit for (2) is that we can perform overlap removal for multiple entities. Arguably, in that case the user wants the visualize multiple graphs at once that don't share a common meaning. For this, having multiple separate graph viewers (each with their own query) side by side is likely a much better option.

To summarize: the big downside of automatic overlap removal (2) is that the user will ultimately loose control over the exact node positions for graphs composed of multiple entities. Because of this, I think we should do (1), with the downside of potentially having some overlaps + a more complex global layout algorithm.

@grtlr grtlr added other Generated by the "Other" issue template 👀 needs triage This issue needs to be triaged by the Rerun team feat-graph-view Everything related to the graph view labels Nov 13, 2024
@abey79
Copy link
Member

abey79 commented Dec 2, 2024

done

@abey79 abey79 closed this as completed Dec 2, 2024
@Wumpf Wumpf changed the title Graph layout for mutliple entities Graph layout for multiple entities Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat-graph-view Everything related to the graph view 👀 needs triage This issue needs to be triaged by the Rerun team other Generated by the "Other" issue template
Projects
None yet
Development

No branches or pull requests

2 participants