Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle self-edges, duplicated nodes, and duplicated edges in graph viewer #8238

Closed
Tracked by #7897
grtlr opened this issue Nov 28, 2024 · 1 comment · Fixed by #8256
Closed
Tracked by #7897

Handle self-edges, duplicated nodes, and duplicated edges in graph viewer #8238

grtlr opened this issue Nov 28, 2024 · 1 comment · Fixed by #8256
Labels
🪳 bug Something isn't working feat-graph-view Everything related to the graph view

Comments

@grtlr
Copy link
Contributor

grtlr commented Nov 28, 2024

Right now we can't draw self-edges. Also, our model around how to handle duplicated nodes and duplicated edges is ambiguous.

@abey79 I think the following makes sense:

  • Duplicated nodes is undefined behavior.
  • Self-edges are ignored by the force-based layout algorithm but shown in the graph view, with a length depending on the distance parameter (potentially multiplied for multiple self edges).
@grtlr grtlr added 🪳 bug Something isn't working feat-graph-view Everything related to the graph view labels Nov 28, 2024
@abey79
Copy link
Member

abey79 commented Nov 28, 2024

Makes sense to me 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working feat-graph-view Everything related to the graph view
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants