Release 0.20.1-alpha.2 #8172
Merged
Release 0.20.1-alpha.2 #8172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerun-bot
added
⛴ release
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
emilk
reviewed
Nov 19, 2024
| @@ -429,7 +429,8 @@ def publish_crate(crate: Crate, token: str, version: str, env: dict[str, Any]) - | |||
| retry_attempts = 5 | |||
| while True: | |||
| try: | |||
| cargo(f"publish --quiet --token {token}", cwd=crate.path, env=env, dry_run=False, capture=True) | |||
| # We added --locked here hoping that `cargo publish` would use the included `Cargo.lock` file, but it doesn't. | |||
There was a problem hiding this comment.
This ultimately didn't help, but it shouldn't hurt either. Keeping it at least makes it obvious next time, that adding it isn't the solution
| @@ -10,7 +10,7 @@ readme = "README.md" | |||
| repository.workspace = true | |||
| rust-version.workspace = true | |||
| version.workspace = true | |||
| include = ["../../LICENSE-APACHE", "../../LICENSE-MIT", "**/*.rs", "Cargo.toml"] | |||
| include.workspace = true | |||
There was a problem hiding this comment.
The main change in this PR is that we always include Cargo.lock in the crate package zip. That doesn't really do anything, unfortunately, but at least it is now consistent.
emilk
added a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next steps
A few hours after the GitHub release is created, will create a
conda feedstock PR.
Make sure Jeremy is on top of it!