Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve generate_changelog.py #17

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Improve generate_changelog.py #17

merged 3 commits into from
Oct 22, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 21, 2024

@emilk emilk added the exclude from changelog Do not include in CHANGELOG.md label Oct 21, 2024
Wumpf pushed a commit to rerun-io/rerun that referenced this pull request Oct 22, 2024
### What
* Closes #7825

When generating the changelog, I accidentally wrote 

> scripts/generate_changelog.py --commit-range 0.18.2..HEAD

and should have done

> scripts/generate_changelog.py --commit-range 0.18.0..HEAD

I've updated `generate_changelog.py` to make the same mistake impossible
in the future.

I've already updated [the GitHub release
notes](https://github.com/rerun-io/rerun/releases/tag/0.19.0) with the
changes in this PR.

* Sibling PR: rerun-io/rerun_template#17

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7844?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7844?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7844)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Wumpf Wumpf merged commit 98c9b34 into main Oct 22, 2024
9 of 10 checks passed
@Wumpf Wumpf deleted the emilk/better-changelog-gen branch October 22, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog Do not include in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants