Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the labels check from the template #8

Closed
wants to merge 1 commit into from

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Apr 24, 2024

This level of changelog management doesn't make sense for our example repos.

Also it's annoying since the labels don't even exist on the project.

@emilk
Copy link
Member

emilk commented Apr 24, 2024

I agree it doesn't make sense for example repos, but it makes sense for something like egui_tiles and ewebsock.

Maybe put it in the Rust-only list in the update-script?

@jleibs
Copy link
Member Author

jleibs commented Apr 24, 2024

This is a distracting can of worms... gating on rust is hacky. Also the merge-blocking feature is probably worth including, so getting rid of this file altogether is the wrong direction.

The fact that --language needs to be specified every time you update is also annoying, and adding something like --project to it highlights that init should really be creating a persisted configuration file in the repo capturing language, project-type, etc.

I'll just create the labels for now and get back to doing something other than over-thinking the repo templating system.

@jleibs jleibs closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants