Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist names #639

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Whitelist names #639

merged 2 commits into from
Nov 9, 2022

Conversation

ewan-escience
Copy link
Collaborator

Fetch ORCID whitelist names

Changes proposed in this pull request:

  • On the ORCID whitelist page, a button is added that, when clicked, fetches all the names of the whitelisted ORCIDs and shows them.

How to test:

  • docker-compose build frontend && docker-compose up
  • Login as admin
  • Add some ORCIDs to the whitelist, both real and fake
  • Click the button, it should be replaced by a spinner
  • When fetching is done, the names should be displayed and the button should be back

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

Copy link
Contributor

@dmijatovic dmijatovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ewan-escience ewan-escience merged commit 8eb9b89 into main Nov 9, 2022
@dmijatovic dmijatovic deleted the whitelist-names branch November 16, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants