Add support for connection_pool gem #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danila
force-pushed
the
connection-pool-support
branch
2 times, most recently
from
616adba
to
7d5ff5b
Compare
danila
force-pushed
the
connection-pool-support
branch
from
7d5ff5b
to
271dd75
Compare
Closed
iloveitaly
requested changes
Oct 26, 2022
danila
force-pushed
the
connection-pool-support
branch
from
ec71c6a
to
a2b9d4d
Compare
danila
force-pushed
the
connection-pool-support
branch
from
cf29256
to
583e8ce
Compare
|
Hey, @iloveitaly thank you for the fastest response! Indeed the initial approach was dirty so I refactored it a bit and extended the specs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for @mperham's connection_pool, in order to make gems compatible without the need to rely on method_missing that is used in wrapper.
This PR was influenced by #135. Unfortunately we can't rely on
respond_to?(:with)anymore, as this method was introduced toredis-rbgem here, so we gotta check class name.