Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Latest Geant4 Versions #31

Closed
lobis opened this issue Mar 6, 2022 · 0 comments · Fixed by #51
Closed

Support Latest Geant4 Versions #31

lobis opened this issue Mar 6, 2022 · 0 comments · Fixed by #51
Assignees
Labels
enhancement New feature or request

Comments

@lobis
Copy link
Member

lobis commented Mar 6, 2022

While adding an example to #30 I found that assembly geometries do not work in Geant4 10.4.3, due to a bug. I am not sure if there is a workaround but I did not find it, the G4PhysicalVolumeStore simply does not have all the physical volumes.

The obvious fix is to support more recent Geant4 versions and to introduce some mechanism to prevent a user to use assembly geometries in old Geant4 versions.

There are probably some changes to be made also to Geant4Lib.

In restG4 it seems like the only changes necessary are to update physicsList.cxx since it uses some deprecated interfaces. It even uses some deprecated interfaces already for 10.4.3, which throw a warning that they may not give correct results.

  • #include <G4EmProcessOptions.hh> used in
        G4EmProcessOptions emOptions;
        emOptions.SetFluo(true);   // To activate deexcitation processes and fluorescence
        emOptions.SetAuger(true);  // To activate Auger effect if deexcitation is activated
        emOptions.SetPIXE(true);   // To activate Particle Induced X-Ray Emission (PIXE)

is deprecated and may not work correctly even in 10.4.3, we should replace this with the correct way.

  • Radioactive decay:
        G4RadioactiveDecay* radioactiveDecay = new G4RadioactiveDecay();
        radioactiveDecay->SetHLThreshold(nanosecond);

This interface also does not work in the newer versions, we need to replace it.

@lobis lobis self-assigned this Mar 26, 2022
@lobis lobis added the enhancement New feature or request label Mar 26, 2022
@lobis lobis linked a pull request Jun 13, 2022 that will close this issue
@lobis lobis closed this as completed in #51 Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant