Add golangci lint config, add many error checks #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRON-666
reviewed
Jan 30, 2021
DRON-666
reviewed
Jan 30, 2021
Most added checks are straight forward.
fd0
force-pushed
the
add-golangci-lint-config
branch
from
af8d672 to
a00e27a
Compare
fd0
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Add a configuration file for
golangci-lintso that we get good results from all the linters. Also, I tried to add all the error checks mentioned byerrcheck, in order to prevent things like #3249.Was the change discussed in an issue or in the forum before?
No.
Checklist
changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits