Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version sniffing for keep-alive-agent #1366

Closed
3 tasks done
retrohacker opened this issue Jun 1, 2017 · 2 comments
Closed
3 tasks done

Remove version sniffing for keep-alive-agent #1366

retrohacker opened this issue Jun 1, 2017 · 2 comments

Comments

@retrohacker
Copy link
Member

  • Used appropriate template for the issue type
  • Searched both open and closed issues for duplicates of this issue
  • Title adequately and concisely reflects the feature or the bug

Feature Request

Use Case

Why do you want this?

Was introduced in 1fca266 for backwards compatibility with v0.10, which is no longer supported.

The version sniffing seems to be causing restify to fall back to the userland implementation of keep-alive-agent for non-released versions of Node.js (i.e. built off of master). See nodejs/node#13325 for more context.

Are you willing and able to implement this?

Yes

@stale
Copy link

stale bot commented Apr 10, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Apr 10, 2018
@stale
Copy link

stale bot commented Apr 24, 2018

This issue has been automatically closed as stale because it has not had recent activity.

@stale stale bot closed this as completed Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant