You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Searched both open and closed issues for duplicates of this issue
Title adequately and concisely reflects the feature or the bug
Feature Request
Use Case
Working on a multi service system where Express.js is used for some services and Restify for others. The middleware is written such that it expects res.status to be chainable, so when passing in Restify objects, the middleware errors:
TypeError: res.status(...).send is not a function
I've written a plugin which provides this: june07@0ec0d88
Following the proper flow to see if I can open a PR for this.
The text was updated successfully, but these errors were encountered:
I don't oppose this change because we already return this on many of the Response methods, so it would be consistent. However, this is definitely a breaking change and it would have to go out on 9.x.
For now, I believe the following would work for both Express and Restify:
@ghermeto Thank you. It's been almost 3 weeks without any further input from @restify/current-core so I've submitted a PR. Also you are absolutely right with the suggestion below, if changing the code was feasible. Otherwise when the code is upstream, or owned by someone else, this PR should help.
Feature Request
Use Case
Working on a multi service system where Express.js is used for some services and Restify for others. The middleware is written such that it expects res.status to be chainable, so when passing in Restify objects, the middleware errors:
TypeError: res.status(...).send is not a function
I've written a plugin which provides this:
june07@0ec0d88
Following the proper flow to see if I can open a PR for this.
The text was updated successfully, but these errors were encountered: