Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using one of the error reporting libraries #260

Open
39555 opened this issue Nov 5, 2024 · 1 comment
Open

Consider using one of the error reporting libraries #260

39555 opened this issue Nov 5, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@39555
Copy link
Contributor

39555 commented Nov 5, 2024

One of the project's goals might be user-friendliness. We already have reedline, which is great. User friendly error would be the huge quality improvement over Bash.

Personally I like annotate-snippets the most for its simplicity and usage in cargo. Than ariadne looks good to me.

@reubeno
Copy link
Owner

reubeno commented Nov 5, 2024

Agreed on the opportunity for differentiated experience. I had previously looked into miette and was impressed with it. Would be great to get an analysis of the pros and cons of each of the candidate options you list.

I'm also expecting that one of the challenges will be ensuring we have the right context for where the error is. (For example, our tokens have source info but it's hard to map our parser AST nodes back to where they came from if an error occurs while evaluating them.)

@reubeno reubeno added the enhancement New feature or request label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants