Add Hashtags to Share Urls #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yup, it's great! |
reuixiy
reviewed
Apr 5, 2020
|
@Syralist I made some adjustments and I'm going to merge this PR if there is no problem. |
Looks like hyphen(-) will make hashtag failed on Twitter.
Syralist
commented
Apr 5, 2020
|
Okay, I just tested that. Seems like Hugo has some kind of "magic", which converts |
|
Yes, I guess the |
|
So I'm going to merge this PR now. Do you have any other suggestions? |
|
No suggestions at the moment. :) |
reuixiy
pushed a commit
that referenced
this pull request
Apr 5, 2020
ulmefors
pushed a commit
to ulmefors/hugo-theme-meme
that referenced
this pull request
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twitter and Facebook allow the addition of hashtags to the share urls, so I added this to the "post-share" partial. It takes the posts tags and appends them to the Urls.
Twitter allows a list of tags, Facebook only allows one tag.
It works but I don't know if the code is good.