-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hashtags to Share Urls #100
Conversation
Yup, it's great! |
@Syralist I made some adjustments and I'm going to merge this PR if there is no problem. |
Looks like hyphen(-) will make hashtag failed on Twitter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this to preserve the capitalization in the tags. I thought this to be better than all lowercase.
Okay, I just tested that. Seems like Hugo has some kind of "magic", which converts |
Yes, I guess the |
So I'm going to merge this PR now. Do you have any other suggestions? |
No suggestions at the moment. :) |
Twitter and Facebook allow the addition of hashtags to the share urls, so I added this to the "post-share" partial. It takes the posts tags and appends them to the Urls.
Twitter allows a list of tags, Facebook only allows one tag.
It works but I don't know if the code is good.