fix: Respect user's preferred theme even when JavaScript isn't enabled #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palant
added a commit
that referenced
this pull request
Jun 5, 2020
…tly selected theme Regression from #169
palant
added a commit
that referenced
this pull request
Jun 7, 2020
* refactor: Do not rely on JavaScript for code highlighting, make dark and light themes consistent * fix: Image brightness reduction in dark mode should work with implicitly selected theme (regression from #169) * chore: Rename dark-theme style file into them-switcher and removed unused code * chore: Update resources folder BREAKING CHANGE: Highlighting customization now works by overriding CSS variables, no longer by overriding theme-specific files
ulmefors
pushed a commit
to ulmefors/hugo-theme-meme
that referenced
this pull request
Nov 22, 2020
ulmefors
pushed a commit
to ulmefors/hugo-theme-meme
that referenced
this pull request
Nov 22, 2020
* refactor: Do not rely on JavaScript for code highlighting, make dark and light themes consistent * fix: Image brightness reduction in dark mode should work with implicitly selected theme (regression from reuixiy#169) * chore: Rename dark-theme style file into them-switcher and removed unused code * chore: Update resources folder BREAKING CHANGE: Highlighting customization now works by overriding CSS variables, no longer by overriding theme-specific files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, theme selection won't work at all if JavaScript is disabled. This is unnecessary, media queries can be performed with CSS only. Only switching themes and storing user's preference requires JavaScript.