fix: make dark theme brighter #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palant
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
I like this, the text is much easier to read now.
Only a slight inconsistency, not sure it matters. --color-contrast-lower now has better contrast in the dark theme than in the light one. Visible for example when you look at related posts border - barely visible in the light theme, very clear in the dark one.
| .theme-icon-light { | ||
| display: none; | ||
| } | ||
| .theme-icon-dark { | ||
| display: inline-block; | ||
| } | ||
| img { | ||
| filter: brightness(50%); | ||
| filter: brightness(75%); |
There was a problem hiding this comment.
Nice, that's something I currently override in my websites (going for 80% but that's pretty much the same).
|
Eagle eye! |
ulmefors
pushed a commit
to ulmefors/hugo-theme-meme
that referenced
this pull request
Nov 22, 2020
The dark theme is not the night theme, so I think we need to increase the contrast for better reading experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dark theme is not the night theme, so I think we need to increase the contrast for better reading experience.