Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errors on 404 page #200

Merged
merged 2 commits into from
Jun 14, 2020
Merged

fix: errors on 404 page #200

merged 2 commits into from
Jun 14, 2020

Conversation

reuixiy
Copy link
Owner

@reuixiy reuixiy commented Jun 14, 2020

After #173, JavaScript is loaded in the head, which makes the 404 page load it also, which caused the following errors on 404 page:

2020-06-14-09-37-51

Fixed #199, maybe.

@reuixiy reuixiy requested a review from palant June 14, 2020 01:50
@palant
Copy link
Collaborator

palant commented Jun 14, 2020

Then again, maybe we can avoid loading the script in the 404 page instead? Would be an even better solution.

{{ if ne .Kind "404" }}

It seems that in all other cases head.html is loaded from baseof.html, so the header is guaranteed to be there.

@reuixiy reuixiy merged commit 87e8586 into master Jun 14, 2020
@reuixiy reuixiy deleted the 404 branch June 14, 2020 15:36
ulmefors pushed a commit to ulmefors/hugo-theme-meme that referenced this pull request Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

起初我以为是我配置问题,看了你们的404页面发现都有问题
2 participants