Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP8266: Use strtok for parsing incoming job #1584

Merged
merged 1 commit into from
Nov 28, 2022
Merged

ESP8266: Use strtok for parsing incoming job #1584

merged 1 commit into from
Nov 28, 2022

Conversation

snakeye
Copy link
Contributor

@snakeye snakeye commented Nov 25, 2022

No description provided.

@snakeye snakeye changed the title Use strtok for parsing incoming job ESP8266: Use strtok for parsing incoming job Nov 25, 2022
@revoxhere
Copy link
Owner

What does that even PR do? Any details would be welcome.

@snakeye
Copy link
Contributor Author

snakeye commented Nov 27, 2022

Yes, my bad. I had to provide more context.

The function strtok is the standard way to separate the string by some delimiter. It makes sense to use it instead of custom implementation.

Use strtok for parsing incoming job
b54d33b 
Mining Job as a structure
revoxhere
revoxhere approved these changes Nov 28, 2022
View reviewed changes
Copy link
Owner

@revoxhere revoxhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@revoxhere revoxhere merged commit 5443665 into revoxhere:master Nov 28, 2022
@revoxhere
Copy link
Owner

Thanks for your input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revoxhere revoxhere revoxhere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snakeye @revoxhere