-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-organized code and a lot of other stuff. #342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re actual extract
…oad (#296) (follows current doclines); a small step towards importability #217
…HTML; fixed a bug in the use of _unescapeHTML (missing _, from d6a9615)
let's elaborate the decision: Python 2.5 is a 6 years old release and "under the current release policy, no security issues in Python 2.5 will be fixed anymore" (!!); also, it doesn't support the new zipfile distribution format.
and stitle is created in process_info() and is cross-filesystem sanitized by sanitize_filename(); closes #164
phihag
added a commit
that referenced
this pull request
May 22, 2012
Re-organized code and a lot of other stuff.
These changes are too good to be left out. Merged all of them. I might change some details though before releasing a new version. |
Closed
8 tasks
joedborg
referenced
this pull request
in joedborg/youtube-dl
Nov 17, 2020
[pull] master from ytdl-org:master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my recent work on youtube-dl. I've been really bold, but I tried to keep it elegant, in line with the philosophy of this project and tested.
Let's enumerate the changes:
youtube_dl
directory. The package gets compiled bymake compile
into an executable zipfile. The zipfile is prepended with a shebang so that it remains executable on Linux.build_exe.py
andwine-py2exe.sh
that creates a Windows EXE automatically using WINE that is able to update itself.wine-py2exe.sh
creates a WINEPREFIX inwine-py2exe/
, installs Python and py2exe inside it and the creates the exe using the setup.py passed as argument (build_exe.py
).-U
writes a bat file and executes it before dying.That pull request includes the following branches, so refer to them for what the changes are:
This is a fast-forward ready merge from the current upstream.