Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abbr_machine #5

Open
qkdefus opened this issue Oct 22, 2021 · 7 comments
Open

abbr_machine #5

qkdefus opened this issue Oct 22, 2021 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@qkdefus
Copy link

qkdefus commented Oct 22, 2021

[abbr_machine] displays blank on my ender 3 pro ( preferably CE3PRO )

thanks

@rgomezjnr
Copy link
Owner

Hi I'll review and see if [abbr_machine] is working on my end.

@rgomezjnr rgomezjnr self-assigned this Oct 23, 2021
@rgomezjnr rgomezjnr added the bug Something isn't working label Oct 23, 2021
@qkdefus
Copy link
Author

qkdefus commented Oct 23, 2021

great, thank you

@rgomezjnr
Copy link
Owner

I was not able to replicate the issue. [abbr_machine] is working as expected from my testing. I tested this in both Cura 4.9.0 and 4.11.0 using the preset Creality Ender-3 Pro printer definition.

  • What Cura version are you using?
  • Are you sure you're using GFF Plus and not GFF (older version of the plugin, deprecated)?
  • Are you using the Ender-3 Pro preset printer definition within Cura? i.e. did you add the printer using the Cura setup wizard after installation, or using the Preferences -> Printers dialogue, or did you copy and paste custom printer definition files into the Cura folder?
  • Are you sure you're using the correct option name [abbr_machine]? Try clicking the Default button on the GFF Plus Edit Format dialogue.

@rgomezjnr
Copy link
Owner

@qkdefus Are you still having this issue? I don't see this behavior.

@qkdefus
Copy link
Author

qkdefus commented Dec 16, 2021

Hi, thank you for your time and effort. Unfortunately I dont have my printer up and running right now due to upgrades and problems with shipping 😅.
(pretty sure iam on latest cura with curas ender3 presset and chep's ender3 profile)

@bryanhunwardsen
Copy link

bryanhunwardsen commented Jul 14, 2022

I can confirm this is (still) broken on at least Cure 5.0.0.
This is for a "CR6-SE" (Cura Displayed Printer Profile Name). I cant answer how this was added, and possibly is part of the problem.
Most of my machine profiles were created a while ago, some from v3 most in v4, most w/ from the Custom Profile as CURA did not have a dedicated predefined profile, some from predefined profiles that were available after major/minor version upgrades or as the result of a corrupt profile needing to be remade from scratch. All of which have been carried across multiple computers using profile backup/restore sync functionality.

This was all working perfectly as far as 4.09-12, likely using the old plugin, but has now stopped working using new plugin on 5.0.0. IIRC, i thought the plugin dynamically generated the abbreviation? It pulls [printer_name] fine. Is the abbreviator choking on the "-" possibly? Or is abbr set in the xml(?) profile on creation?

Thats all the info I have to give, so far, but can confirm there still is "an" issue with it working correctly.

Follow-Up, new plugin version does nothing on 4.11(?) Since the new plugin does not show (appear) to show the formatting in real time on the Prepare/Preview screens(or allow access to modify the formatting), I was trying to understand when do format changes take effect (re-import model, restart cura, real-time, after slicing) but I cannot discern when it happens, but in 4.11 nothing works even w/ default set.

@rgomezjnr
Copy link
Owner

All of which have been carried across multiple computers using profile backup/restore sync `functionality.

If you guys delete the printer profile then add a new one from the Cura default printer profiles is [abbr_machine] still empty?

I could also try importing your printer profiles and attempt to recreate the issue if you upload the profile. I'm not sure if this is actually causing the issue or not.

I just tried recreating the issue in Cura 5 but I haven't been able to recreate it. I deleted the existing CE3Pro machine profile, added back the default printer profile for Creality Ender-3 Pro, and the [abbr_machine] option results in CE3PRO.

i thought the plugin dynamically generated the abbreviation?

This is how GFF+ obtains the [abbr_machine] parameter. It simply spits out whatever string is stored in the abbr_machine property of print_information object. There is no manipulation or modification of this string directly by GFF+.

https://github.com/rgomezjnr/GcodeFilenameFormatPlus/blob/gff%2B/GcodeFilenameFormatPlus.py#L126

abbr_machine = print_information._abbr_machine
printer_name = global_stack.getName()

Is the [abbr_machine] option always empty for you for all printer profiles? Can you try adding a different printer profile just for testing? If you're able to get non-empty [abbr_machine] strings for other printer profiles but you do when only using 1 printer profile then the problem is likely with that specific printer profile.

@bryanhunwardsen I added Creality CR-6 SE printer profile in Cura 5 and [abbr_machine] is working for me, Cura 5.0.0 GFF+ 1.0.0 Windows 10.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants