Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add to remark" option adds an extra space #853

Open
Brickspert-au opened this issue Apr 4, 2024 · 2 comments
Open

"Add to remark" option adds an extra space #853

Brickspert-au opened this issue Apr 4, 2024 · 2 comments

Comments

@Brickspert-au
Copy link

When using the "add to remark" option there is an extra space being add into the remarks field before the remark being added and after the existing remark.

To Reproduce
Steps to reproduce the behavior:
in an open file with pieces added and something already in the remarks field

  1. highlight an item
  2. right click in the remarks field and select "Add to remark..."
  3. enter the desired text and click ok or press 'enter'
  4. notice how there is an unintentional space

Expected behavior
There should be an unintentional space in the field before the add remark and after the existing remark

System information
Please tell us which system you are running on and which BrickStore version you are using.

BrickStore 2024.3.1 (build: 1203)

  • brickstore.ldraw: 14 Mar 2024 11:17:09 +1100
  • brickstore.locale: en
  • build.arch: x86_64
  • build.compiler: Microsoft Visual-C++2019 (192930154)
  • build.date: 2024-03-25T23:08:20.000
  • build.host: fv-az533-485
  • build.number: 1203
  • build.qt.version: 6.6.2
  • hw.cpu: AMD FX(tm)-8350 Eight-Core Processor
  • hw.cpu.arch: x86_64
  • hw.gpu: AMD Radeon HD 7800 Series
  • hw.gpu.arch: amd
  • hw.memory.gb: 8.0
  • os.arch: x86_64
  • os.productname: Windows 10 Version 22H2
  • qt.debug: false
  • qt.platformname: windows
  • qt.version: 6.6.2
  • windows.tabletmode: false

Additional context
Add any other context about the problem here.
You can also attach BSX files, but GitHub only accepts these if added to a ZIP file first.

@rgriebl
Copy link
Owner

rgriebl commented Apr 4, 2024

This is by design -- the add and remove functionality for the remarks and comments fields works on words, not characters. See also #553
Supporting this (as well as case-sensitivity) is not that easy though, as it requires custom dialogs to be implemented for both the desktop and mobile UI.
I'll keep this open as a suggestion though.

@ZZJHONS
Copy link
Contributor

ZZJHONS commented Apr 10, 2024

On most programs the search and replace function works that way, Brickstore is the only one that I know of doesn't. To do a mass change in the remarks (or comments) I need to use another text editor. When I redistribute some section on my store I need to mass change remarks to add letters or numbers so when sorting orders by remark is all in a path. Also at the end of the remarks I store some data too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants