Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little quantity parsing bug #895

Closed
TeupFleup opened this issue Jun 11, 2024 · 1 comment
Closed

Little quantity parsing bug #895

TeupFleup opened this issue Jun 11, 2024 · 1 comment

Comments

@TeupFleup
Copy link

Hi! When I import a Bricklink order into BrickStore, the parts with a quantity of 1000 and up are not parsed. They show up as "-".
For some reason, Bricklink sees fit to add (American) punctuation to these numbers, e.g. "1,234". I assume that's what causes parsing them to break down.

I'm importing an order as a parts list by downloading the order, changing the ORDERS and ORDER tags into INVENTORY and removing the order data tags. Works perfectly except for the parsing of these quantities.

The decimals having American notation (".") on my European machine appears to be no problem at all, though - prices and weights are imported correctly. I guess all it has to do is simply disregard any commas in the file.

@rgriebl
Copy link
Owner

rgriebl commented Oct 3, 2024

BrickStore has a workaround in place for that glitch, but it only uses that workaround on actual orders (it would be waste of CPU time otherwise).
All the current quirks are documented here: https://github.com/rgriebl/brickstore/blob/main/src/bricklink/global.h#L12
I decided to keep these workarounds as minimal as possible. This is for my own sanity and also to be able to quickly adapt to fixes on BrickLink's side.
If you manually change the file type, you'll have to fix these quirks as well I'm afraid. Or you could pester BrickLink to finally start fixing these rather simple bugs.

@rgriebl rgriebl closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants