Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context node can no longer be moved or opened if saved in a workflow in closed state #15

Closed
MokkaBoss1 opened this issue Sep 11, 2023 · 3 comments

Comments

@MokkaBoss1
Copy link

Hi,

I am a big fan of this node and use it extensively but I noticed this issue recently on a number of my workflows.

Can you check it?

thanks

MokkaBoss1

@rgthree
Copy link
Owner

rgthree commented Sep 12, 2023

Yea, there's a bug in ComfyUI's code. I filed it at comfyanonymous/ComfyUI#1448

It's for any node that start starts collapsed and has this kind of input (not just my nodes and not just the context node). The good news is that I do have a fix, but it's a part of a much larger change bringing some awesome new feature to the nodes.

In the mean time, you can "unstick" them, but right clicking and selecting "collapse" from the ComfyUI node menu. That seems to fix the issue for Comfy.

@MokkaBoss1
Copy link
Author

Hi,

many thanks for the workaround - I tried it and it works! Many thanks and I hope the underlying code gets fixed at some point.

Kind regards

MokkaBoss1

@rgthree
Copy link
Owner

rgthree commented Sep 14, 2023

Great. I actually have a fix for this, but it's grouped with a bunch of stuff on this repo's dev branch at https://github.com/rgthree/rgthree-comfy/tree/dev . Unfortunately, it requires some optimization in comfyui itself. Once comfyanonymous/ComfyUI#1502 is fixed and/or comfyanonymous/ComfyUI#1502 is merged, then this can land in rgthree/rgthree-comfy main.

@rgthree rgthree closed this as completed Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants