Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What new features should I include for version 0.4? #26

Open
rguerreiro opened this issue Aug 21, 2014 · 6 comments
Open

What new features should I include for version 0.4? #26

rguerreiro opened this issue Aug 21, 2014 · 6 comments
Labels

Comments

@rguerreiro
Copy link
Owner

One that is on the pipeline for a very long time is parsing the OS. But that is already done in the ua-parser package. Is it really necessary on the express-device?

What other ideas do you have that make sense on adding to express-device?

@renancouto
Copy link

Well I don't know if this is not an out of scope, but some feature detection would be nice. Like testing for touch events! I know that Modernizr does that pretty good, but it would be awesome if we could get that information before the client.

@mklemme
Copy link

mklemme commented Oct 23, 2014

How about the option for a user to force desktop - or other - view. E.g. "switch to desktop site" would set an ignore variable or other solution.

@arvidkahl
Copy link

If a function like get_type could somehow yield which device was recognized (instead of just the type), that would be splendid - even it it was just the part of the regex that matched. A full device name string would be incredibly useful though. get_device_name would make this already great lib magical. That and the force-desktop mode mentioned.

@cbanbury
Copy link

Hi, would it be possible to add a list of custom rules to the config. It would be nice to add custom filters for specific user agent strings that are either missing or that are special cases and to be treated differently.

@wamoyo
Copy link

wamoyo commented Jul 14, 2015

I'd love to know the viewport width or device width.

@rguerreiro
Copy link
Owner Author

For version 0.4.0 I'll be adding support for express v4.0. For the versions after that I'll start to pick some of your ideas. Thank you for all the input. Keep it coming ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants