-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[battle_engine] Several issues with mega evolution #1916
Comments
Also, the mega evolutions occurs in the wrong order, because of this : |
Mega Evolution wish causes other mega evolution to display the fervent wish message because the isWishMegaEvo field of MegaEvolutionData is only a bool. And once it's set I didn't see a place where it was cleared, letting the game think that all the mega evolutions that follow are wish as well. This field should be 1 bool per battler, even one byte, or more carefully cleared/set when it should. I'll try to fix these issues in a single PR. |
gbagfx to respect user CC setting
All of what's mentionned below is fixed in this PR.
According to https://bulbapedia.bulbagarden.net/wiki/Mega_Evolution switching should happen before mega evolving.
As of now it doesn't change much, because the mid-turn speed recalculation aren't implemented (except for #1914 which might include said changes in the future), but when they are, this inconsistency will matter.
The text was updated successfully, but these errors were encountered: