MOVE_BREAKNECK_BLITZ is broken

[AaghatIsLive]

Untitled.video.-.Made.with.Clipchamp.mp4

It always uses the 4th move instead of the selected one.

[AlexOn1ine]

It is not just an issue with MOVE_BREAKNECK_BLITZ. It is related to z moves.

Basically anytime there is a status move of the same type in one of the 3 next slots it deletes the z move effect of the previous damaging dealing move in function IsViableZMove

            if (IS_MOVE_STATUS(move))
                gBattleStruct->zmove.chosenZMove = move;
            else
                gBattleStruct->zmove.chosenZMove = GetTypeBasedZMove(move, battlerId);

Changing it to just this line solves the bug

gBattleStruct->zmove.chosenZMove = GetTypeBasedZMove(move, battlerId);

Though I'm not sure if this creates a different problem but it shouldn't since it is just setting the type of the move z move, right?

[AaghatIsLive]

            if (IS_MOVE_STATUS(move))
                gBattleStruct->zmove.chosenZMove = move;
            else
                gBattleStruct->zmove.chosenZMove = GetTypeBasedZMove(move, battlerId);

Changing it to just this line solves the bug

gBattleStruct->zmove.chosenZMove = GetTypeBasedZMove(move, battlerId);

I'm not sure if this creates a different problem but it shouldn't since it is just setting the type of the move z move, right?

@AlexOn1ine Tested it out and this happened,

It forced me to use my zmove on a move of another type

[AlexOn1ine]

Yeah, was able to reproduce. I think I know what is happening but good that I didn't PR this. Each time there is a Z move that is past the clicked slot it tries to use it if you tried it previously. Thanks for testing it out.

Taunt will not prevent the target from using a status Z-Move

It shouldn't even prevent it.

[AlexOn1ine]

Something similar is also happening with the current implementation.

[AaghatIsLive]

            if (IS_MOVE_STATUS(move))
                gBattleStruct->zmove.chosenZMove = move;
            else
                gBattleStruct->zmove.chosenZMove = GetTypeBasedZMove(move, battlerId);

Changing it to just this line solves the bug

gBattleStruct->zmove.chosenZMove = GetTypeBasedZMove(move, battlerId);

I'm not sure if this creates a different problem but it shouldn't since it is just setting the type of the move z move, right?

@AlexOn1ine I think your suggestion fixes it. The taunt one was a separate issue, and I haven't had any issues with Z-moves since then.

except for this one where the move crashed the game in a double battle, but it could be a different issue.

[AlexOn1ine]

except for this one where the move crashed the game in a double battle, but it could be a different issue.

Does the issue happen without the change? If it does then I PR my change and maybe something comes up in the review.

[AaghatIsLive]

Does the issue happen without the change? If it does then I PR my change and maybe something comes up in the review.

@AlexOn1ine Yeah, it does. You should go ahead and PR this.