Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More issues with the battle item refactor #2967

Closed
Jaizu opened this issue Apr 30, 2023 · 5 comments
Closed

More issues with the battle item refactor #2967

Jaizu opened this issue Apr 30, 2023 · 5 comments

Comments

@Jaizu
Copy link

Jaizu commented Apr 30, 2023

image

Probably related to:
#2943 #2934

@u8-Salem
Copy link

I dont think the first issue can be addressed with tests since you either do an action or you dont. there is no "going back" for tests.
regarding the second I could not find anything that would indicate an issue with the limited info that is given. For tests, hyper potions work in singles aswell as doubles.
doublehyperpotion

@AsparagusEduardo
Copy link
Collaborator

Can anyone try to replicate this manually?

@LOuroboros
Copy link
Collaborator

LOuroboros commented May 18, 2023

Can anyone try to replicate this manually?

Can confirm the Full Restore issue.
FullRestore

EDIT: I don't know about the modern behavior of the item, but in vanilla Pokémon Emerald, the Full Restore is used immediately before choosing the action of the 2nd Pokémon, which is why it makes sense not to be able to go back.

Can't confirm the Hyper Potion one though.
HyperPotion

I'm noticing there's an empty space before the Player's name is printed in the potion usage's text string, likely not intentional.

@Jaizu
Copy link
Author

Jaizu commented May 18, 2023

@LOuroboros probably some stuff was fixed with #2940

@AsparagusEduardo
Copy link
Collaborator

#3022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants