Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The debug menu doesn't report the value of the very first flag (FLAG_TEMP_1) correctly #3403

Closed
LOuroboros opened this issue Oct 10, 2023 · 4 comments · Fixed by #3796
Closed
Labels
bug Bug status: unconfirmed This bug has not been reproduced yet

Comments

@LOuroboros
Copy link
Collaborator

LOuroboros commented Oct 10, 2023

Description

Title.

The debug menu sometimes displays the state of the FLAG_TEMP_1 as TRUE and sometimes it displays it as FALSE, even though by default it's always set to FALSE. It took me a hot minute while working on a project of mine to realize it wasn't my fault, lel.

mGBA_20231010_191006264

Version

upcoming (Edge)

Upcoming Version

70fbf9e

Discord contact info

lunos4026

@LOuroboros LOuroboros added bug Bug status: unconfirmed This bug has not been reproduced yet labels Oct 10, 2023
@AsparagusEduardo
Copy link
Collaborator

Please check if #3390 fixes it

@LOuroboros
Copy link
Collaborator Author

To clarify because I feel like the .gif may not portray the issue accurately, what I did here was enter the Debug Menu, check the state of the flag and press the B button which closes the whole thing. I did it a total of 3 times as it can be seen there.

@LOuroboros
Copy link
Collaborator Author

Please check if #3390 fixes it

Will do.

@LOuroboros
Copy link
Collaborator Author

I left the compiler run after a make clean, started a clean save too and sadly, the issue is still there, @AsparagusEduardo.

commit 612da3255342a7f1c00d735d08968839d3500c88 (HEAD -> upcoming)
Merge: 70fbf9e a34e0f6
Author: LOuroboros lunosouroboros@gmail.com
Date: Tue Oct 10 19:16:14 2023 -0300

Merge branch 'RHH/pr/upcoming/debugCleanup2' of https://github.com/AsparagusEduardo/pokeemerald into upcoming

commit 70fbf9e (upstream/upcoming, upstream/HEAD)
Author: ghoulslash 41651341+ghoulslash@users.noreply.github.com
Date: Mon Oct 9 21:35:00 2023 -0400

Opportunist Ability (#2994)

Co-authored-by: Eduardo Quezada D'Ottone eduardo602002@gmail.com
Co-authored-by: ghoulslash pokevoyager0@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug status: unconfirmed This bug has not been reproduced yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants