Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gTrainers out-of-bounds data access #4215

Closed
AsparagusEduardo opened this issue Feb 20, 2024 · 1 comment
Closed

gTrainers out-of-bounds data access #4215

AsparagusEduardo opened this issue Feb 20, 2024 · 1 comment
Labels
bug Bug status: confirmed This bug has been confirmed to exist in the codebase
Milestone

Comments

@AsparagusEduardo
Copy link
Collaborator

AsparagusEduardo commented Feb 20, 2024

Description

As discussed on Discord, recently I found that tests and other situations that cause gTrainerBattleOpponent_A/B to be set to values equal or higher than TRAINERS_COUNT, making it so that it reads data out bounds. This manifested in #4022's tests after #4176 was merged, causing it to set up Electric Terrain at the beginning of the tests.
mGBA_iLTm0OtZ6s

Version

upcoming (Edge)

Upcoming/master Version

5e79fcd

Discord contact info

AsparagusEduardo

@AsparagusEduardo AsparagusEduardo added bug Bug status: unconfirmed This bug has not been reproduced yet labels Feb 20, 2024
@AsparagusEduardo AsparagusEduardo added this to the 1.8.0 milestone Feb 20, 2024
@AsparagusEduardo AsparagusEduardo added status: confirmed This bug has been confirmed to exist in the codebase and removed status: unconfirmed This bug has not been reproduced yet labels Feb 20, 2024
@AsparagusEduardo
Copy link
Collaborator Author

#4216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug status: confirmed This bug has been confirmed to exist in the codebase
Projects
None yet
Development

No branches or pull requests

1 participant