Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamax AI sees base moves rather than promoted Max Moves #4650

Closed
WillKolada opened this issue May 29, 2024 · 3 comments
Closed

Dynamax AI sees base moves rather than promoted Max Moves #4650

WillKolada opened this issue May 29, 2024 · 3 comments
Assignees
Labels
bug Bug category: battle-ai Pertains to Battle Engine Upgrade's AI status: unconfirmed This bug has not been reproduced yet

Comments

@WillKolada
Copy link

Description

When deciding which move to use, a Dynamax Pokemon will reference the base move in its moveset rather than the promoted Max Move. This is especially problematic for any status move that should be interpreted as Max Guard.

This appears to be because gChosenMoveByBattler[gBattlerAttacker] and gBattleMons[gBattlerAttacker].moves[gChosenMovePos] do not promote their respective moves to the Max versions and are what the AI references. gChosenMove, conversely, does promote the move.

Version

upcoming (Edge)

Upcoming/master Version

06cbc9a

Discord contact info

Special K#8400

@WillKolada WillKolada added bug Bug category: battle-ai Pertains to Battle Engine Upgrade's AI status: unconfirmed This bug has not been reproduced yet labels May 29, 2024
@tertu-m tertu-m self-assigned this Jul 13, 2024
@hedara90
Copy link
Collaborator

hedara90 commented Sep 1, 2024

Partially fixed by #5299 (I think), it now reads the correct base power of moves.
But it didn't change anything regarding secondary effects of Max Moves.

@AlexOn1ine
Copy link
Collaborator

But it didn't change anything regarding secondary effects of Max Moves.

I don't think they need to get a score increase based on their secondary effect. They are primarily moves with a high base power, the secondary effect is a bonus. If you do evaluate them you risk the AI not going for best damage in this case

@AlexOn1ine
Copy link
Collaborator

#5299
Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug category: battle-ai Pertains to Battle Engine Upgrade's AI status: unconfirmed This bug has not been reproduced yet
Projects
None yet
Development

No branches or pull requests

4 participants