Cmd_averagestats has UB

[Bassoonian]

Description

https://discord.com/channels/419213663107416084/774393519569502268/1263628135417774081

Version

master (default, unreleased bugfixes)

Upcoming/master Version

No response

Discord contact info

No response

[u8-Salem]

luckytyphlosion pointed out their solution would not be compatible with agbcc. I suggest we wait with this one until it is fully deprecated and removed (#4994)

[AlexOn1ine]

If there is a solution it wouldn't be bad to fix on 1.8

[u8-Salem]

If there is a solution it wouldn't be bad to fix on 1.8

for which release is agbcc's deprecation sheduled? we should do this fix in the same release

[AlexOn1ine]

If there is a solution it wouldn't be bad to fix on 1.8

for which release is agbcc's deprecation sheduled? we should do this fix in the same release

it is being disabled in 1.9 but deprecated in 1.10. Though it would be a bugfix for 1.8.6 since this one is released at the same time 1.9 is

[mrgriffin]

A simple fix would be to write something like:

u16 *GetBattlerStat(struct BattlePokemon *battler, u32 stat)
{
  switch (stat)
  {
  case STAT_ATTACK: return &battler->attack;
  case STAT_DEFENSE: return &battler->defense;
  ...
  default: return NULL;
  }
}

static void Cmd_averagestats(void)
{
  CMD_ARGS(u8 stat);

  u16 *stat1 = GetBattlerStat(&gBattleMons[gBattlerAttacker]), cmd->stat);
  u16 *stat2 = GetBattlerStat(&gBattleMons[gBattlerTarget]), cmd->stat);
  u16 avg = (*stat1 + *stat2) / 2;
  *stat1 = *stat2 = avg;

  gBattlescriptCurrInstr = cmd->nextInstr;
}