Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in code efibootmgr.c #79

Closed
zpah opened this issue Dec 28, 2017 · 2 comments
Closed

Error in code efibootmgr.c #79

zpah opened this issue Dec 28, 2017 · 2 comments

Comments

@zpah
Copy link

zpah commented Dec 28, 2017

Wrong format string in: https://github.com/rhboot/efibootmgr/blob/2e018c08b92c800961ec010a6a4eeb34e8f3faa0/src/efibootmgr.c#L1620

@zpah zpah changed the title Error in code Error in code efibootmgr.c Dec 28, 2017
@rbisewski
Copy link
Contributor

For context, in the latest code, I believe the this line is currently located here. In my testing I can confirm that is broken and not printing correctly. Luckily it's an easy fix:

Replace this...

error(16, "%s", "Could not set active state for %s%04X", prefices[mode], opts.num);

... with this...

error(16, "Could not set active state for %s%04X", prefices[mode], opts.num);

This seems to work on my system. I'll create a pull request in a few minutes.

@vathpela
Copy link
Contributor

vathpela commented Mar 6, 2019

Thanks, I've pulled your PR.

@vathpela vathpela closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants