-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctrl IQ, Inc EL9 Shim 15.8 for x64 #420
Comments
Can we get the UKI's SBAT, or you aren't providing UKI kernel? |
We are not moving forward with signing UKI build at this time. |
@aronowski @SherifNagy Please let me know if I can provide additional information to help the review process. |
@jason-rodri nothing at the moment, we are working through the queue |
The application looks alright, apart from one minor nitpick:
The duplicated explanation in the answer hasn't been fixed yet, just like in the EL8 application. ;-) |
Review of ciqliq-shim-EL9-x64-20240518
Shim
GRUB2
Kernel
NotesAlong side the note from @aronowski
Other than those few notes, LGTM, we will need one more reviewer |
Review of
|
As discussed yesterday using certwrapper to import the Rocky Linux CA is likely fine. We just need confirmation that certwrapper is ready for production use and can be signed. @jsetje do you know the status of certwrapper? |
Signed binaries returned from MSFT. I understand the that there is still a question around certwrapper. Do we still want to keep this open until @jsetje replies? |
Yeah let's keep this open until there is a definite answer if you can sign certwrapper |
Confirm the following are included in your repo, checking each box:
What is the link to your tag in a repo cloned from rhboot/shim-review?
https://github.com/ctrliq/ciq-shim-build/releases/tag/ciqliq-shim-EL9-x64-20240705
What is the SHA256 hash of your final SHIM binary?
SHA256 (shimx64.efi) = f67bf3bb333d1e8ecfbb372f93ad7056e12c43c4eedc335e235c66b7af9fa940
What is the link to your previous shim review request (if any, otherwise N/A)?
Ctrl IQ, Inc Shim 15.8 for x64 & ia32 #366
If no security contacts have changed since verification, what is the link to your request, where they've been verified (if any, otherwise N/A)?
Jason Rodriguez
Michael Young
The text was updated successfully, but these errors were encountered: