-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpaquita Linux shim-15.8 x64 and aarch64 #426
Comments
Contact verification has been done previously, marking as such |
Review for
|
@THS-on thanks for your review!
It was returned signed by Microsoft some time after the issue was closed. I should have mentioned this in a comment there.
Added. The new tag is https://github.com/akodanev/shim-review/tree/alpaquita-shim-x64-aarch64-20240624.
There are no plans to sign UKI or systemd-boot. However, we will most likely make the fwupd component available for review in the next shim update. |
@akodanev thanks for the clarifications. LGTM from my side. |
Review of alpaquita-shim-x64-aarch64-20240624
Shim
GRUB2
Kernel
Notes
Other than those few notes, LGTM |
OK. I am hoping that this will be the next release of the shim so that the patch will already be there.
There is none upstream. Maybe it's only helpful if there's more than one such shim/grub based on this Alpine version.
Thank you @SherifNagy! |
@SherifNagy as mentioned Alpine does not have one. As the current package is mostly vanilla GRUB2 + peimage patches, I'm fine with not having an Alpine specific one. |
marking it as accepted |
The signed binaries received. Closing this as completed. |
Confirm the following are included in your repo, checking each box:
What is the link to your tag in a repo cloned from rhboot/shim-review?
https://github.com/akodanev/shim-review/tree/alpaquita-shim-x64-aarch64-20240624
What is the SHA256 hash of your final SHIM binary?
What is the link to your previous shim review request (if any, otherwise N/A)?
#325
If no security contacts have changed since verification, what is the link to your request, where they've been verified (if any, otherwise N/A)?
#325 (comment)
The text was updated successfully, but these errors were encountered: