Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing GITHUB_TOKEN secret on workflow_call #106

Merged
merged 4 commits into from
Feb 24, 2022

Conversation

mkj-is
Copy link
Contributor

@mkj-is mkj-is commented Jan 14, 2022

Closes #87.

Adds GITHUB_TOKEN secrets to all the other secrets supplied to workflow_call.

I am not sure the constant is added at the right place, but when I added the secret to BuiltinGlobalVariableTypes in expr_sema.go it was breaking some more tests.

@mkj-is mkj-is changed the title Fix missing GITHUB_ACTION secret on Fix missing GITHUB_TOKEN secret on workflow_call Jan 14, 2022
Copy link
Owner

@rhysd rhysd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this.

@rhysd rhysd merged commit af27f8a into rhysd:main Feb 24, 2022
rhysd added a commit that referenced this pull request Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding workflow_call to a workflow fails lint
2 participants