Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message format for GitHub Actions #20

Closed
ybiquitous opened this issue Aug 2, 2021 · 7 comments
Closed

Message format for GitHub Actions #20

ybiquitous opened this issue Aug 2, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@ybiquitous
Copy link

Hi, thank you so much for creating this nice tool! 😄

When I tried running actionlint on GitHub Actions, It took some time to set up.
Here is my setup code:

https://gist.github.com/ybiquitous/c72834b30882d3c1f9c105683d4c1137

I use Problem Matcher in the setup code, but I doubt it difficult for many users to use Problem Matcher.

If actionlint could output messages with the ::warning or ::error format of Actions, it might be easier to set up.
(But, for the purpose, severities may be needed...)

For example:

$ actionlint -format github
::error file=.github/workflows/test.yml,line=10,col=15::Something went wrong

What do you think about this idea?

@rhysd rhysd added the enhancement New feature or request label Aug 2, 2021
@rhysd
Copy link
Owner

rhysd commented Aug 2, 2021

How about using reviewdog? It has support for actionlint. Perhaps proposing actionlint support to super-linter might be another option.

@ybiquitous
Copy link
Author

Yes, reviewdog or super-linter is good another option!

But, I think it is useful to also provide a straightforward way when getting starting with actionlint, because users would not need to learn more about other integrations like reviewdog.

@rhysd
Copy link
Owner

rhysd commented Aug 2, 2021

I understood. I'm considering if we can make this feature a bit more generic.

It might be better to provide functionality to specify the output format by Go template notation so that users can specify output format freely. And we would be able to provide an example configuration for GitHub Actions workflow using the template.

@ybiquitous
Copy link
Author

It might be better to provide functionality to specify the output format by Go template notation

It's like the --format option of the docker command. It sounds like a nice idea to me! 👍🏼

@rhysd
Copy link
Owner

rhysd commented Aug 2, 2021

Sounds nice. I'll check the docker's option before designing this feature.

@rhysd rhysd closed this as completed in 74c3bb9 Aug 10, 2021
@ybiquitous
Copy link
Author

@rhysd Great work! Thank you so much! 😊 👏🏼

@rhysd
Copy link
Owner

rhysd commented Aug 11, 2021

This feature was released at v1.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants