You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using the syntax ${{ env.FOO }} for accessing environment variable can cause severe security issues, it's recommended to use the regular shell syntax $FOO or $Env:FOO for PowerShell.
I already made a PR for this #332, but you asked for an issue where we can discuss this.
If you don't want to raise an alert for using ${{ env.FOO }} could we at least allow a wildcard character like in the PR to allow peoples to add new untrusted inputs ?
The text was updated successfully, but these errors were encountered:
Hi,
Using the syntax
${{ env.FOO }}
for accessing environment variable can cause severe security issues, it's recommended to use the regular shell syntax$FOO
or$Env:FOO
for PowerShell.Here is a vulnerable workflow example:
An attacker could open the following issue to get arbitrary code execution inside the GitHub runner:
As a result the file
pwned.txt
is created:Using this workflow would prevent the command injection vulnerability:
I already made a PR for this #332, but you asked for an issue where we can discuss this.
If you don't want to raise an alert for using
${{ env.FOO }}
could we at least allow a wildcard character like in the PR to allow peoples to add new untrusted inputs ?The text was updated successfully, but these errors were encountered: