Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secrets context in steps.with.args wrongly detected as not allowed #497

Closed
Natim opened this issue Dec 30, 2024 · 5 comments
Closed

secrets context in steps.with.args wrongly detected as not allowed #497

Natim opened this issue Dec 30, 2024 · 5 comments

Comments

@Natim
Copy link

Natim commented Dec 30, 2024

Action lint wrongly detects secrets context as unusable in the step.with.args property:

on:
  schedule:
    - cron: 0 */12 * * *
  workflow_dispatch:

jobs:
  translations-pull-request:
    name: Update translations pull request
    runs-on: ubuntu-24.04
    permissions:
      contents: write
      id-token: write
      pull-requests: write
    steps:
      - name: Lokalise upload django.po fr
        uses: docker://lokalise/lokalise-cli-2:v3.0.2
        with:
          args: >-
            lokalise2 file upload
            --config lokalize.yml
            --file ./app/locale/fr/LC_MESSAGES/django.po
            --lang-iso="fr"
            --cleanup-mode="true"
            --distinguish-by-file
            --token ${{ secrets.LOKALISE_API_TOKEN }}

image

@Natim Natim changed the title secrets context in step.args wrongly detected as not allowed secrets context in steps.with.args wrongly detected as not allowed Dec 30, 2024
@rhysd
Copy link
Owner

rhysd commented Dec 30, 2024

This is a duplicate of #495. It is already fixed at the main branch.

@rhysd rhysd closed this as completed Dec 30, 2024
@Natim
Copy link
Author

Natim commented Dec 30, 2024

Thank you @rhysd I will wait for the next release then.

@rhysd
Copy link
Owner

rhysd commented Dec 30, 2024

I'm going to make the next release this weekend.

@rhysd
Copy link
Owner

rhysd commented Jan 4, 2025

v1.7.6 for fixing this issue was released.

@Natim
Copy link
Author

Natim commented Jan 5, 2025

Thanks @rhysd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants